Re: Broken ProgramTargetName () when !CrossCompiling

[Alan Hourihane <alanh at fairlite dot demon dot co dot uk>]

Sounds logical, but I hasten to add - I've not really looked at this at all
since August, but a test would be good.

Alan.

On Thu, Sep 27, 2001 at 09:20:06AM -0400, Harold Hunt wrote:
> The real problem is that my update to ComplexProgramTarget_1 is now working
> just like the default ComplexProgramTarget_1.  This is to say, it is
> wrapping each program in PROGRAMS with ProgramTargetName.  What we're seeing
> is that certain Imakefiles that use ComplexProgramTarget or
> SimpleProgramTarget are randomly wrapping some of the programs in PROGRAMS
> with ProgramTargetName and they are putting non-program targets in PROGRAMS
> (the xmkmf script), thus causing, respectively, double wrapping of program
> targets (.exe.exe) and wrapping of non-program targets (xmkmf.exe).
> 
> In other words, some Imakefiles have the assumption that ProgramTargetName
> () doesn't add anything to the executable name, which is the case on
> probably every other XFree86 platform except Cygwin.
> 
> All we have to do is rework a couple Imakefiles to remove that assumption.
> 
> For example, in xc/config/util/Imakefile, couldn't we just pull 'xmkmf' out
> of PROGRAMS, and add an 'all:: xmkmf', then remove the ProgramTargetName ()
> wrappers from programs that are in PROGRAMS?  I'll test it sometime, but I
> just want to know if that sounds logical.
> 
> Harold
> 
> > -----Original Message-----
> > From: Alan Hourihane [mailto:alanh@fairlite.demon.co.uk]
> > Sent: Thursday, September 27, 2001 6:33 AM
> > To: Harold Hunt
> > Cc: cygx
> > Subject: Re: Broken ProgramTargetName () when !CrossCompiling
> >
> >
> > I've removed that line now. Let's hope someone can fix the other part of
> > the problem.
> >
> > Alan.
> >
> > On Wed, Sep 26, 2001 at 04:16:12PM -0400, Harold Hunt wrote:
> > > Right, I'm doing a 'make World' too.
> > >
> > > I'm just saying that I think wrapping ProgramTargetName in #if
> > > CrossCompiling is causing more problems than it solves.  I
> > think the real
> > > solution is more complex, and we'd better just wait until we can fix it
> > > properly, rather than changing the documentation, fixing the
> > problem, then
> > > changing the documentation back.  (Cause I've got extremely limited time
> > > these days)
> > >
> > > Harold
> > >
> > > > -----Original Message-----
> > > > From: Alan Hourihane [mailto:alanh@fairlite.demon.co.uk]
> > > > Sent: Wednesday, September 26, 2001 4:12 PM
> > > > To: Harold Hunt
> > > > Cc: cygx
> > > > Subject: Re: Broken ProgramTargetName () when !CrossCompiling
> > > >
> > > >
> > > > I'm doing a 'make World' now.
> > > >
> > > > It wasn't just xmkmf, I remember that xc/programs/xinit was
> > > > involved too and
> > > > there maybe others. I'll let you know when the build is complete.
> > > >
> > > > Alan.
> > > >
> > > > On Wed, Sep 26, 2001 at 03:21:20PM -0400, Harold Hunt wrote:
> > > > > Alan,
> > > > >
> > > > > Hold on, I thought we established that xmkmf was not an
> > > > executable, it was
> > > > > just a shell script, right?
> > > > >
> > > > > So, the makefile is broken because it tries to build xmkmf, not
> > > > because it
> > > > > is appending any or too many .exe's, right?
> > > > >
> > > > > Harold
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: cygwin-xfree-owner@sources.redhat.com
> > > > > > [mailto:cygwin-xfree-owner@sources.redhat.com]On Behalf Of Alan
> > > > > > Hourihane
> > > > > > Sent: Wednesday, September 26, 2001 1:31 PM
> > > > > > To: Harold Hunt
> > > > > > Cc: cygx
> > > > > > Subject: Re: Broken ProgramTargetName () when !CrossCompiling
> > > > > >
> > > > > >
> > > > > > On Wed, Sep 26, 2001 at 01:19:32PM -0400, Harold Hunt wrote:
> > > > > > > > Don't you remember this thread about how xc/config/util is
> > > > > > appending too
> > > > > > > > many .exes - things are becoming 'xmkmf.exe.exe' etc ?
> > > > > > >
> > > > > > > I remember that, and I remember thinking that the real solution
> > > > > > was to fix
> > > > > > > the particular IMakefile involved by removing the extra
> > > > > > ProgramTargetName
> > > > > > > ().
> > > > > > >
> > > > > > Submit a patch in the usual way....
> > > > > >
> > > > > > Alan.