Re: (patch seq: 5151) config file support for cygwin port

[Alexander Gottwald <Alexander dot Gottwald at informatik dot tu-chemnitz dot de>]

On Mon, 21 Jan 2002, Harold Hunt wrote:

> The code looks fine to me, but, I don't want the patch committed until some
> effort is made to follow the formatting of the other files in hw/xwin.
> Also, I've got a few problems with the Imakefile changes, as well as with
> the InitOutput.c changes.

Do you have a "styleguide"? Or maybe just the indent settings?
 
> #
> # Coding style complaints - winkeybd.c, winconfig.c, winmsg.c
> #
[snip]

> I could count hundreds of instances of the above example in winconfig.c;
> however, there are whole blocks of your code that do put each '{}' on their
> own lines, so I'd just like to see the nonconforming lines fixed.

took that from hw/xfree86/common :)

> Function types are not always on the line above the function name, and the
> space between the function name and the opening '(' is missing.  (see
> winmsg.c).
> 
> Furthermore, I'd like you to run each file through Emacs, selecting all
> text, then run "C->Indent Line or Region"; this will get the parameter lists
> lined up correctly, etc.
> 

Ok, I think ident can fix this easily

> # Imakefile complaints
> 
> I don't think that your changes to programs/Xserver/Imakefile are correct.
> Platform-specific changes to the SUBDIRS list should be avoided at all
> costs.  Try to find some other way to add XWINPARSEDIR to the list of
> directories to be compiled.
 
I followed the example of the other platforms :)

> # InitOutput.c
> 
> You've got #define macro definitions on line 247 or so, when they should be
> up at the top of the file.
> 

I choosed to place it near the function, since it's only used there and
does imo belong to the function

bye
    ago
-- 
 Alexander.Gottwald@informatik.tu-chemnitz.de 
 http://www.gotti.org           ICQ: 126018723
 phone: +49 3725 349 80 80	mobile: +49 172 7854017
 4. Chemnitzer Linux-Tag http://www.tu-chemnitz.de/linux/tag/lt4