Re: Built XWin on mingw - with patches

[Jon TURNEY <jon dot turney at dronecode dot org dot uk>]

On 01/11/2011 20:39, Ryan Pavlik wrote:
> Not sure if this is the right forum for this, but it seemed more

This is absolutely the correct list.

Thanks very much for putting in the effort to do this.

> specific and probably more appropriate than the overall xorg lists.
> I wanted to build a native windows X server (essentially an
> open-source Xming). I had to patch a number of the packages along the
> way, but did eventually arrive at a build that worked.  I looked at
> and used a few of the Xming patches, but only generally went to those
> when the naive approach didn't work.

This may be a problem.

The material on the Xming website is licensed under a Creative Commons 
license, which is not compatible with the X11 license.  So, patches from the 
Xming website are not acceptable unless the author has agreed to re-license 
them appropriately.

> I'm looking for some feedback on the patches so that they can get into
> the main line of the projects.
>
> I built using mingw-cross-env, with my fork here that includes the
> dependency packages: https://bitbucket.org/rpavlik/mingw-cross-env/
> This builds everything except the xorg-server module (ignore the fact
> there's an xorg-server makefile there - the patches aren't up to date
> for that module.)
>
> Patches for these dependencies are as follows, in that mingw-cross-env
> repo (These should all have commit messages from being exported from
> git format-patch):
> libX11-1-add-xwinsock-include, libX11-2-windows-threads,
> libX11-3-MinGW-lacks-caddr_t
> libXaw-1-need-winsock
> libXfont-1-dummy-readlink
> libxcb-1-fix-include-order-with-Xdmcp, libxcb-2-wsastartup - this last
> one fixes running libX11 apps built for Windows, including the
> integrated multi-window WM.
> xkbcomp-1-Use-X11-Xwindows.h, xkbcomp-2-Look-in-windows-base-dir-too -
> this last one supports the "RELOCATE_PROJECTROOT" option in the XWin
> server - should still work fine in the normal case though.

I've quickly looked over these patches and in general they look good, and I'd 
be happy to help get them merged upstream.

A couple of general points I'd make though:

It helps a great deal in reviewing if the comments state why the change is a 
good idea (e.g. what problem it fixes), rather than just describing the change 
which is made.

I also noticed that a bit more care might be needed with the define you are 
using to enable platform specific code: WIN32 and __MINGW__ should not be used 
interchangeably.  WIN32 will also be defined when building VcXsrv, and neither 
is defined on Cygwin.

So, can you post your patches here, preferably in git-send-email format so we 
can review them in detail?

--
Jon TURNEY
Volunteer Cygwin/X X Server maintainer

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://x.cygwin.com/docs/
FAQ:                   http://x.cygwin.com/docs/faq/