This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: base-files patch


On Fri, Mar 25, 2005 at 04:37:26PM +0000, Eric Blake wrote:
>Considering the recent thread on rxvt and PS1, I propose the following
>patches to /etc/default/etc/profile.  In addition to fixing the default
>PS1 for bash to correctly delineate non-printing characters, it fixes
>the following additional bugs: When using case, you do not need to
>quote a command substitution; this is particularly important since
>"`""`" is non-portable, just use case `""` instead.  Sorting is not
>necessarily strictly alphanumeric in other locales (not that cygwin has
>good locale support, but still...).  Also, `info coreutils dircolors'
>recently changed to recommend eval "`dircolors ...`", due to the
>security hole mentioned in
>http://lists.gnu.org/archive/html/bug-coreutils/2004-12/msg00058.html.

I'm not sure I understand the removal of "``" for "portability" in the
same patch which changes

  A=foo
  export A

to
  export A=foo

I've never seen a shell that didn't understand "``" but I have seen shells
which didn't understand export A=foo.

Personally, I wish we wouldn't play any prompt games in the system profiles.
I'd rather just either just have the standard prompt that the shell uses
or my own customized version rather than assuming that we all know what
the cygwin users want for a prompt.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]