This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: services not starting with 20060104 snapshot


On Thu, Jan 05, 2006 at 09:34:07PM -0500, Christopher Faylor wrote:
>That was supposed to fix the problem of console windows appearing when the
>service is allowed to interact with the desktop.

Does this do anything, Larry?

cgf

Index: fhandler_console.cc
===================================================================
RCS file: /cvs/uberbaum/winsup/cygwin/fhandler_console.cc,v
retrieving revision 1.155
diff -u -p -r1.155 fhandler_console.cc
--- fhandler_console.cc	5 Jan 2006 16:26:22 -0000	1.155
+++ fhandler_console.cc	6 Jan 2006 02:54:56 -0000
@@ -146,7 +146,7 @@ tty_list::get_tty (int n)
 void __stdcall
 set_console_state_for_spawn (bool noncygwin_process)
 {
-  if (noncygwin_process && fhandler_console::need_invisible ())
+  if ((1 || noncygwin_process) && fhandler_console::need_invisible ())
     return;
 
   HANDLE h = CreateFile ("CONIN$", GENERIC_READ, FILE_SHARE_WRITE,
@@ -1825,6 +1825,9 @@ fhandler_console::fixup_after_fork_exec 
 
 bool NO_COPY fhandler_console::invisible_console;
 
+// #define WINSTA_ACCESS (WINSTA_READATTRIBUTES | STANDARD_RIGHTS_READ | STANDARD_RIGHTS_WRITE | WINSTA_CREATEDESKTOP | WINSTA_EXITWINDOWS)
+#define WINSTA_ACCESS STANDARD_RIGHTS_READ
+
 bool
 fhandler_console::need_invisible ()
 {
@@ -1856,9 +1859,8 @@ fhandler_console::need_invisible ()
       h = horig = GetProcessWindowStation ();
       if (myself->ctty == -1)
 	{
-	  if (!(h = CreateWindowStation (NULL, 0, WINSTA_ALL_ACCESS, &sec_all_nih)))
-	    h = CreateWindowStation ("CygwinInvisible", 0, WINSTA_ALL_ACCESS,
-				     &sec_all_nih);
+	  if (!(h = CreateWindowStation (NULL, 0, WINSTA_ACCESS, NULL)))
+	    h = CreateWindowStation ("CygwinInvisible", 0, WINSTA_ACCESS, NULL);
 	  termios_printf ("CreateWindowStation(\"CygwinInvisible\", %p), %E", h);
 	  if (h)
 	    {


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]