This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: bash-3.1-7 BUG

David Rothenberger wrote:
On 9/13/2006 4:46 PM, Volker Quetschke wrote:
mwoehlke wrote:
Eric Blake wrote:
mwoehlke <mwoehlke <at>> writes:
... If the file starts life binary mode (ie. was on a binary
mount), skip the check for \r in the scan (under the assumption that
on a binary mount, \r is intentional and not a line ending to be
collapsed), and use lseeks.
Sounds good! That will satisfy my request to not silently work on files
that should be broken. :-)

I'm seeing the next "make doesn't work anymore with DOS ... feature" coming
up here, only that it is bash this time. (snip)

... It is definitely in the eye of the beholder if one calls shell
scripts that worked so far as broken just because they have /r/n line

I strongly agree with this. The users I support would be much happier if bash could continue to work correctly with \r\n in scripts on binary mounts.

It sounds like bash will have to scan the first line regardless of the mount type (to check for a binary file), so perhaps the decision to treat \r as intentional or not could be an option?

I think this is getting a little off-track. Another option just means another area for people who don't understand what's going on to trip and fall and then come and bug the list as a result. IMO, there's already such an option, even without changing bash. It's called 'd2u'. Let's not over-think and over-do things here. There's pain involved in that too. I'm not convinced that it's worth the pain to all for the benefit of a few. Of course, I firmly believe that what can and will be done here is Eric's call. He's the one that will be maintaining it.

Larry Hall                    
RFK Partners, Inc.                      (508) 893-9779 - RFK Office
216 Dalton Rd.                          (508) 893-9889 - FAX
Holliston, MA 01746

Unsubscribe info:
Problem reports:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]