This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: missing definition of __STRING macro in standard cygwin headers


Eric Blake wrote:

> Then that's a bug in FAAC.  Using any identifier in the __ namespace is
> admitting that your code is relying on implementation details, and it
> deserves to break when ported to a different implementation.
> 
> That said, submit a patch, and it will probably be applied, since it won't
> violate any standards to provide such a define.

Not to mention the fact that it's incredibly silly to rely on libc
headers to define something as trivial as the stringify operator which
is a standard part of the C language.  Does it also require
__COMMENTBEGIN to be defined as /*?  __BRACEBEGIN as {?  Why not just
use #x in the code in the first place?

By the way, I don't see why you can't just build this package like:

./configure CPPFLAGS="-D__STRING=#x" ..rest of configure options..

There's no need to modify any source for something this trivial.

Brian

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]