This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 'cp' utility bug when <dest-name>.exe file exist.


>On 06/08/2010 09:42 AM, RISINGP1@nationwide.com wrote:
>> As to the "cp" issue, while IMHO, it should go ahead and do the copy,
>> a more instructive error message would be helpful:
>> 
>> cp: cannot create regular file `my': File 'my.exe' exists
>
>Huh?  Do the copy, then give a failure message?  No.  A failure message
>should only occur if the copy failed.
>
>Did you mean "continue to fail, but make the failure message more
>friendly?"  If so:
>Patches to coreutils welcome.  But be aware that this error message uses
>the equivalent of perror(), where EEXIST would not have quite that
>wording.  In other words, such a patch would be pretty invasive, to
>recognize the exact errno value that cygwin1.dll returns in this
>particular failure-to-create case, then massaging just that error case
>into your desired message, so I probably won't be writing the patch any
>time soon (I've got higher-priority things on my plate at the moment).
>
>Or did you mean "change it to succeed, in spite of the naming conflict",
>in which case there is no failure message and nothing to patch in 
coreutils.
>
>-- 
>Eric Blake   eblake@redhat.com    +1-801-349-2682
>Libvirt virtualization library http://libvirt.org
>

Eric -

Sorry for the confusion.  I understand how it arose.

What I meant:

1) IMHO, "cp" should do the copy.  Also, IMHO, there is no naming 
conflict;
   "foo" and "foo.exe" are not the same name.  (I come from a long UNIX
   background.)  No error message should be issued.

2) If "cp" is going to fail the copy, a more instructive error message
   would be helpful.

I understand the issue with using the generic (this is NOT a bad thing)
perror().  But maybe in this case, the "cp" command could go the extra 
mile
(needed because of Microsoft), and explain the reason for this particular
failure if it is going to fail the command.  I would not recommend 
changing
perror() - what a mess (not to mention, a ton of work) that would create!

Thanks.

Phil Rising   risingp1@nationwide.com

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]