This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] tests: don't assume getdtablesize () <= 10000000


On Wed, Sep 25, 2013 at 06:05:07AM -0600, Eric Blake wrote:
>On 09/24/2013 10:32 PM, Christopher Faylor wrote:
>
>>> This patch causes failures on at least test-fcntl and test-dup2 on
>>> cygwin (both 32-bit and 64-bit); there, getdtablesize() currently
>>> returns the current runtime value, but this value starts at 256, and
>>> automatically expands as needed at runtime up to 3200.  I think cygwin
>>> should be patched to make getdtablesize() return a constant 3200 (rather
>>> than the current runtime value);
>> 
>> Why?  What does "3200" have to do with anything?  There is not supposed
>> to be a hard-coded upper limit.
>> 
>
>But there IS a hard-coded limit:
>
>http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/dtable.h?rev=1.59&content-type=text/x-cvsweb-markup&cvsroot=src

Sorry, you're right.  I should have checked before talking.  And, it
apparently you were expecting me to check.

Since you've previously made modifications in this area, why not supply
a simple patch?

cgf

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]