This is the mail archive of the
mailing list for the Cygwin project.
Re: Problem with new acl code and cdrtools
- From: Ismail Donmez <ismail at i10z dot com>
- To: cygwin at cygwin dot com
- Date: Mon, 8 Feb 2016 16:13:30 +0200
- Subject: Re: Problem with new acl code and cdrtools
- Authentication-results: sourceware.org; auth=none
- References: <CAFo71_4fDB3WkhXTL7eybNzKh2idVF1UHb7oJjaxFshcS9BFUg at mail dot gmail dot com> <20160208131835 dot GC12975 at calimero dot vinschen dot de> <CAFo71_5=KT=kJY-wz0EZWZ_LBriCjX2s6=5PSVhHRSxx-A92qg at mail dot gmail dot com> <20160208141015 dot GD12975 at calimero dot vinschen dot de>
On Mon, Feb 8, 2016 at 4:10 PM, Corinna Vinschen
> On Feb 8 15:31, Ismail Donmez wrote:
>> On Mon, Feb 8, 2016 at 3:18 PM, Corinna Vinschen
>> <email@example.com> wrote:
>> > On Feb 8 12:01, Ismail Donmez wrote:
>> >> Hi,
>> >> cdrtools has some code to detect Solaris style ACLs:
>> >> #if defined(HAVE_ACL) && defined(HAVE_FACL) && \
>> >> defined(HAVE_ACLFROMTEXT) && defined(HAVE_ACLTOTEXT)
>> >> # define HAVE_SUN_ACL 1 /* Sun UFS ACL's present */
>> >> #endif
>> >> Since cygwin still seems to be defining aclfromtext() and acltotext()
>> >> functions (which are not defined in POSIX) cdrtools thinks this a
>> >> Solaris-style system and get up getting a compile error later on.
>> > Probably due to including sys/acl.h. Does swtiching to cygwin/acl.h
>> > help? Or changing the above check to prefer POSIX ACLs over Solaris
>> > ACLs?
>> This is a generic code so I don't want to add a cygwin specific
>> dependency there. Is there a preprocessor definition for cygwin
>> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
> If you include cygwin/version.h you could use the version definitions.
> Alternatively we could allow to use the Solaris ACL functions even if
> only including sys/acl.h, given some macro:
> #ifdef __USE_OLD_SOLARIS_ACL_FUNCTIONS
> # include <cygwin/acl.h>
> [...POSIX definitions...]
> Would that help?
That should help, I cook a patch and send to cdrecord maintainer.
Thanks a lot.
Problem reports: http://cygwin.com/problems.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple