This is the mail archive of the
ecos-discuss@sourceware.cygnus.com
mailing list for the eCos project.
small bug in aeb_serial driver
- To: ecos-discuss at sourceware dot cygnus dot com
- Subject: [ECOS] small bug in aeb_serial driver
- From: Dave Airlie <david dot airlie at drua dot ie>
- Date: Tue, 1 Feb 2000 17:43:27 +0000 (GMT)
Hi,
I spotted a bug in 1.2.1 arm AEB serial driver that is still in
CVS... the patch below fixes it... the isr symbol is a #define in
serial.h, so like is done for lsr earlier in the file I've put the _
before the real one...
all small letter #defines are not nice things
this bug doesn't break anything but it does confuse things when reading
the code..
Dave.
Index: aeb_serial.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/io/serial/current/src/arm/aeb_serial.c,v
retrieving revision 1.5
diff -r1.5 aeb_serial.c
309,311c309,311
< unsigned char isr;
< isr = port->isr & 0x0E;
< if (isr == ISR_Tx) {
---
> unsigned char _isr;
> _isr = port->isr & 0x0E;
> if (_isr == ISR_Tx) {
313c313
< } else if (isr == ISR_Rx) {
---
> } else if (_isr == ISR_Rx) {
--
David Airlie, Software Engineer
Drua Technologies Ltd, Innovation Centre, National Tech Park, Limerick.
t: +353-61-503075 / f: +353-61-338065 / David.Airlie@drua.ie