This is the mail archive of the ecos-discuss@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: vrc4373_serial.c


Chris Morrow wrote:
> 
> Ah, the comment at the start of ns16550_serial_DSR() explains it.

You mean vrc4373_serial_DSR() presumably.

> You have to check channel A for both sets of interrupts.
> 
> Having a similar comment in vrc4373_serial_init() would be useful.

Done.
 
> Chris Morrow wrote:
> >
> > In the function vrc4373_serial_init() in
> > .../devs/serial/mips/vrc4373/current/src/vrc4373_serial.c
> > should the third argument to the cyg_drv_interrupt_create() call
> > be vrc4373_chan->base instead of VRC4373_SCC_BASE+SCC_CHANNEL_A?
> >
> > I guess this board only has one serial port, so this wouldn't
> > matter that much.

And it has two :-).

Jifl
-- 
Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS  Tel: +44 (1223) 728762
"Plan to be spontaneous tomorrow."  ||  These opinions are all my own fault

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]