Re: [ECOS] Patch redboot tcp, suggestion

[Jonathan Larmour <jlarmour at redhat dot com>]

Hendrik Ruijter wrote:
> 
> Acknowledgements for retransmissions of segments
> with sequence numbers lower than the assumed last
> acknowledged were never sent.
> 
> The code at present sends an ACK on every segment
> which should be improved together with proper window
> advertisment.

[ I'm not the expert on this code, so bear with me as I don't have time to
look at this in detail (in the context of ecos-discuss)... ]

I'm not completely convinced that this can be completely correct - the
problem you describe may exist, but this fix may have other side effects.

So just so I can be clear on this: the code you've #if 0'd out could cause
an ack to be sent for a sequence number later than the one that the
retransmission was actually requesting?

But if so, what _will_ send the ack?

The logging changes should be fine though.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine

-- 
Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
and search the list archive: http://sources.redhat.com/ml/ecos-discuss