This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
RE: libc stdio package dependency wrong?
- From: "Koeller, T." <Thomas dot Koeller at baslerweb dot com>
- To: 'Jonathan Larmour' <jifl at eCosCentric dot com>
- Cc: "ecos-discuss (E-Mail)" <ecos-discuss at sources dot redhat dot com>
- Date: Wed, 3 Sep 2003 17:08:06 +0200
- Subject: RE: [ECOS] libc stdio package dependency wrong?
> Jonathan Larmour wrote:
> > Koeller, T. wrote:
> >
> >> Hi,
> >>
> >> the stdio package (CYGPKG_LIBC_STDIO) requires
> >> CYGPKG_IO_SERIAL_HALDIAG. Is this intended? I
> >> want to use a regular /dev/tyyx device instead,
> >> so I could get rid of the haldiag device, but I
> >> can't because of this dependency.
> >>
> >> Wouldn't it be better to have a cdl_interface
> >> for tty drivers to implement and use that instead
> >> of requiring the haldiag driver?
> >
> >
> > Nah, just want to catch the simple case. Instead, I think
> we can get
> > away with something like
> >
> > requires { (CYGDAT_LIBC_STDIO_DEFAULT_CONSOLE=="/dev/ttydiag" ?
> > CYGPKG_IO_SERIAL_HALDIAG : 1) }
>
> Oops, I never finished.... what I was going to say was: try
> it and see,
> and if it does what you expect I'll commit it.
>
> Jifl
Here's the patch, works as expected.
tk
--- packages-orig/language/c/libc/stdio/current/ChangeLog 2003-08-20
10:58:11.000000000 +0200
+++ packages/language/c/libc/stdio/current/ChangeLog 2003-09-03
16:58:04.000000000 +0200
@@ -1,3 +1,7 @@
+2003-09-03 Thomas Koeller <thomas.koeller@baslerweb.com>
+
+ * cdl/stdio.cdl: only require "/dev/haldiag" if actually using it.
+
2003-08-12 Scott Wilkinson <scott@alliantnetworks.com>
* src/common/fclose.cxx (fclose): fclose would seg-fault if passed
--- packages-orig/language/c/libc/stdio/current/cdl/stdio.cdl 2003-03-06
21:57:26.000000000 +0100
+++ packages/language/c/libc/stdio/current/cdl/stdio.cdl 2003-09-03
16:17:36.000000000 +0200
@@ -58,7 +58,6 @@
include_dir cyg/libc/stdio
parent CYGPKG_LIBC
requires CYGPKG_IO
- requires CYGPKG_IO_SERIAL_HALDIAG
requires CYGPKG_LIBC_I18N
implements CYGINT_ISO_STDIO_FILETYPES
implements CYGINT_ISO_STDIO_FILEACCESS
@@ -67,6 +66,8 @@
implements CYGINT_ISO_STDIO_DIRECT_IO
implements CYGINT_ISO_STDIO_ERROR
implements CYGINT_ISO_STDIO_STREAMS
+ requires { (CYGDAT_LIBC_STDIO_DEFAULT_CONSOLE ==
"\"/dev/ttydiag\"" ? \
+ CYGPKG_IO_SERIAL_HALDIAG : 1) }
requires { CYGBLD_ISO_STDIO_FILETYPES_HEADER == \
"<cyg/libc/stdio/stdio.h>" }
requires { CYGBLD_ISO_STDIO_FILEACCESS_HEADER == \
--
Before posting, please read the FAQ: http://sources.redhat.com/fom/ecos
and search the list archive: http://sources.redhat.com/ml/ecos-discuss