This is the mail archive of the
ecos-discuss@sources.redhat.com
mailing list for the eCos project.
Re: cs8900a_int_vector
- From: Gary Thomas <gary at mlbassoc dot com>
- To: bob dot koninckx at o-3s dot com
- Cc: ecos-discuss at sources dot redhat dot com
- Date: Sun, 18 Apr 2004 07:03:30 -0600
- Subject: Re: [ECOS] cs8900a_int_vector
- Organization: MLB Associates
- References: <1082290420.9650.2.camel@pc-002>
On Sun, 2004-04-18 at 06:13, Bob Koninckx wrote:
> file devs/eth/cl/cs8900a/current/src/if_cs8900a.c
>
> static int
> cs8900a_int_vector(struct eth_drv_sc *sc)
> {
> cs8900a_priv_data_t *cpd = (cs8900a_priv_data_t*)sc->driver_private;
> return (cpd->interrupt) ? 1 : 0;
> }
>
> Does anybody know the rationale of the return statement? Shouldn't this
> simply be
>
> return (cpd->interrupt)
Yes, what's there is clearly wrong. Most importantly, this would keep
GDB via ethernet from ever seeing ^C interrupts.
--
Gary Thomas <gary@mlbassoc.com>
MLB Associates
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss