This is the mail archive of the
ecos-discuss@sourceware.org
mailing list for the eCos project.
Re: Re dBoot: "fis load -d" allows "go" even if it fails
- From: Gary Thomas <gary at mlbassoc dot com>
- To: Renà Nielsen <rbn at vitesse dot com>
- Cc: ecos-discuss at ecos dot sourceware dot org
- Date: Wed, 28 Nov 2007 07:51:29 -0700
- Subject: Re: [ECOS] Re[ECOS] dBoot: "fis load -d" allows "go" even if it fails
- References: <13993780.post@talk.nabble.com>
Renà Nielsen wrote:
> Hello,
>
> If you do a
> fis load -d my_image
>
> and my_image is not a valid zip-image, it will not be loaded. That's fine.
> But a following "go" will jump to the img->entry_point anyway.
>
> When loading an image without the -d option and CYGSEM_REDBOOT_FIS_CRC_CHECK
> is defined and the checksum-check fails, it will set entry_addr to
> NO_MEMORY. I think the same thing should happen when the unzip fails.
Send a patch :-)
BTW, I've looked at your other patch and in general I think it's
fine. It is rather involved, so we need a Copyright assignment
before I can consider it for commitment.
http://ecos.sourceware.org/assign.html
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss