This is the mail archive of the
ecos-discuss@sourceware.org
mailing list for the eCos project.
Re: arm SPI1 cdl bugfix, new variant support
- From: vibisreenivasan <vibi_sreenivasan at cms dot com>
- To: John Dallaway <john at dallaway dot org dot uk>
- Cc: eCos Discuss <ecos-discuss at ecos dot sourceware dot org>
- Date: Fri, 10 Apr 2009 11:46:55 +0530
- Subject: [ECOS] Re: arm SPI1 cdl bugfix, new variant support
- References: <49DCA91E.7070700@dallaway.org.uk>
- Reply-to: vibi_sreenivasan at cms dot com
hi John,
On Wed, 2009-04-08 at 14:39 +0100, John Dallaway wrote:
> Hi Szentirmai
>
> Szentirmai Gergely wrote:
>
> > I have discovered an error in spi_at91.cdl
> >
> > cdl_option CYGHWR_DEVS_SPI_ARM_AT91_BUS1 {
> > active_if CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1
> > display "Enable support for SPI bus 1"
> > flavor bool
> > default_value 0
> > description "Enable this option to add support for the
second
> > SPI peripheral. The most AT91 devices only have
one bus"
> > }
> >
> > CYGINT_DEVS_SPI_ARM_AT_HAS_BUS1 is wrong,
CYGINT_DEVS_SPI_ARM_HAS_BUS1
> > is the right value.
>
> See Bugzilla 1000737:
>
> http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000737
>
> > And I added support for SAM7A3, and definitions for the MCI
interface.
> > What is the right way to post my changes?
>
> Contributions are best made as attachments in Bugzilla. Create a new
> Bugzilla report and set the component field to "Patches and
contributions".
>
Cant we use ecos-patches mailing list to send patches.
In fact i have send a patch for adding I2C support for AT91 H/W.
But i didnt get any review comments from maintainers.
> For changes to existing code, please generate a patch against the
latest
> sources in our CVS repository using "cvs -q diff -U5". For new files
and
> packages, simply generate a compressed tarball (.tar.bz2).
>
> The eCos maintainers will then review your contribution.
>
> Thank you
>
> John Dallaway
Thanks & regards
vibi
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss