Re: [ECOS] build_bootp_record() support dns server address

[Andrew Lunn <andrew dot lunn at ascom dot ch>]

On Fri, Jan 10, 2003 at 05:31:00PM +0900, Motoya Kurotsu wrote:
> Hi Andrew, jifl;
> 
> On Thu, Jan 09, 2003 at 07:25:18PM +0100, Andrew Lunn wrote:
> > > >I have a counter proposal. 
> > > >
> > > >Two new CDL options. A bool CYGPKG_NS_DNS_DEFAULT which
> > > >enables/disables the use of a default address. A data
> > > >CYGDAT_NS_DNS_DEFAULT_SERVER which is the IP address of the server. 
> > > >
> > > >init_all_network_interfaces() then has some code inside
> > > >
> > > >#ifdef CYGPKG_NS_DNS_DEFAULT_SERVER
> > > >
> > > >to turn the string into an struct in_addr and pass it to
> > > >cyg_dns_res_init()
> > > 
> > > I prefer this then.
> 
> I agree with your idea. And I have another suggestion.
> 
> When bootp is disabled, domain name is neither set in init_net().
> However a default domain name can be specified in the same way as 
> ip address of dns server that you showed me. In another word, 
> we have another CDL option CYGDAT_NS_DNS_DEFAULT_DOMAIN_NAME and 
> init_all_network_interfaces() has setdomainname() inside
> #ifdef CYGDAT_NS_DNS_DEFAULT_DOMAIN_NAME. 
> 
> Please tell me how you think of it and check the patch
> at the bottom. 

I thought about this while doing the default server, but didn't have
the time. I would prefer it if the domain name had two CDL options
like the default server. One to enable it and the second to set the
value. I can imaging times when you want a hard coded domain name, but
not the server.

I will make this change today and post another patch.

  Andrew