This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 2 more fixes to arm/arch/.../redboot_linux_exec.c


On Fri, 2003-01-17 at 17:42, Patrick Doyle wrote:
> This time, I'll start by attaching the patch file.  Then I'll describe
> what's in it.  (Now I just have to hope I attached the right one... :-)
> 
> Anyway, I ran into a problem in the copy loop in redboot_linux_exec.c when
> the length of the kernel was not a multiple of 4.  (It surprised me that the
> kernel length would not be a multiple of 4, but for whatever reason, the end
> of the particular kernel I was working with that day, with whatever
> toolchain I was using that day, had a bunch of strings, and they were not
> padded out to a multiple of 4 length).  The copy loop, which decremented the
> count by 4 every time, ran for a very long time. :-(
> 
> The other problem that I fixed was that the size of the memory that was
> reported to my kernel was double what I thought it should be.  This confused
> me tremendously since the comment in the code indicated that it should not
> double the size when it is already a power of two, but I suspect somebody
> made a change to 'hal_msbindex()' that didn't get propagated to this
> function.
> 
> Finally, this patch also includes my previous patch changing INITRD to
> INITRD2 as per recent arm kernels.  I don't know if this hasn't been
> included yet because you've been too busy to commit it to CVS, or if you
> have a philosophical disagreement over whether it should be included or not.
> If the later, please let me know.
> 

Actually, it all looks fine to me - I've applied these changes.

Thanks.

-- 
------------------------------------------------------------
Gary Thomas                 |
MLB Associates              |  Consulting for the
+1 (970) 229-1963           |    Embedded world
http://www.mlbassoc.com/    |
email: <gary@mlbassoc.com>  |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]