This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: synch eth patch
note: this should really be a public discussion. My opinion is
not the only one that counts :-)
On Wed, 2003-02-12 at 00:14, Jani Monoses wrote:
> In normal circumstances I would agree with you but IMHO this is not
> one of those :)
> No other driver in devs/eth uses EINVAL so the problem as I see it is
> that making that -1 isn't really going to affect a thing.
> I did not want to replace an EINVAL from say the posix compat package
> Should that ever happen just ignore my mail.In fact ban me from the list :)
> So I can define EINVAL in my config it's the synth target after all but
> the main reason for the patch was this inconsistency with other eth drivers.
> Already too much time wasted on this minor issue.
>
My question would be - "does the synthetic ethernet driver build
[without changes] when using one of the other stacks?" If so, then
IMO it's not the driver's fault.
> > On Tue, 2003-02-11 at 09:53, Jani Monoses wrote:
> > > hi
> > > no patch this time I just wanted to hear some definitive answer regarding the
> > > s/EINVAL/-1/ patch I sent today.
> > > Andrew || Gary || Jonathan please aye or nay it so I don't hold my breath :)
> > >
> >
> > I agree with Andrew - why can't you just get EINVAL defined
> > in your configuration?
> >
--
------------------------------------------------------------
Gary Thomas |
MLB Associates | Consulting for the
+1 (970) 229-1963 | Embedded world
http://www.mlbassoc.com/ |
email: <gary@mlbassoc.com> |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------