This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: edb7211 flash without CYGHWR_IO_FLASH_DEVICE_NOT_IN_RAM


On Tue, 2003-04-01 at 07:12, Jani Monoses wrote:
> > On Tue, 2003-04-01 at 06:41, Jani Monoses wrote:
> > > Hi
> > > this makes the flash of edb7xxx put flash functions in 2ram. sections
> > > instead of implementing CYGHWR_IO_FLASH_DEVICE_NOT_IN_RAM and use flash_dev_query
> > > instead of directly calling flash_query.
> > > I tested this and it's ok.
> > 
> > Why not just retrofit this driver to use the generic Intel StrataFlash
> > driver?  That should make things much simpler in the long run.
> > 
> > n.b. This was one of the very first FLASH drivers written, and thus
> > came long before any of the generic driver setups were ready.
> > 
> 
> I did that last year, made it use 28fxxx and worked fine. I don't know whether I submitted it
> or just asked if I should but I got no answer...I can dig that patch out and 
> send it.I saw that 28fxxx does not use disable/enable cache macros as some other
> drivers do and I don't know if that's the way to go or not because flash drivers are so different
> among each other in ecos
> I'm willing to work on cleanup issues like this if it's Ok and someone will review the changes

I'm sorry if you sent something before that was dropped - so much of 
that happened in the waste-time (the last half of 2002).

I'll be glad to review the changes (and even more glad to purge all old
drivers!).  The only problem is testing, which I will have to leave to
you (I assume that since you are sending such patches, you have access
to this hardware).

> Only with the cache macros in is the code in 28F equivalent to edb

I think this may be because I had some trouble with the cache (it didn't
seem to ever turn off).  Maybe you can isolate this and get it fixed 
while you make these changes.

> So if this looks fine I'll send the edb patch which makes use of the generic intel driver.
> If you say I shoudl go with strata instead of 28 I'll do that.And by the way something 
> I raised a couple of times before the other intel generic flash (bootblock) is not used by any package
> and is superceded by the others anyway.

I think the StrataFlash driver is the one to use - it's very flexible 
and can handle most any of that family of devices.  I'm also pretty
sure that it does 100% supercede the "bootblock" driver.

As for your changes below, I don't think they are required.  The upper
level of the driver (io/flash/...) handles the caches fully so that
the physical drivers never need bother with it.

-- 
------------------------------------------------------------
Gary Thomas                 |
MLB Associates              |  Consulting for the
+1 (970) 229-1963           |    Embedded world
http://www.mlbassoc.com/    |
email: <gary at mlbassoc dot com>  |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]