This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: thumb support


Bart Veer wrote:
"Daniel" == Daniel =?iso-8859-1?q?N=E9ri?= <daniel.neri@sigicom.com> writes:


    Daniel> Bart Veer <bartv@ecoscentric.com> writes:
    >> +		            ((CYGBLD_ARM_ENABLE_THUMB_INTERWORK || CYGSEM_HAL_ROM_MONITOR) ? "-mthumb-interwork " : "") .

Daniel> Isn't the check for CYGSEM_HAL_ROM_MONITOR redundant?

[Bart said, effectively "yes" :-)]

I applied the below patch.

Jifl


Index: ChangeLog =================================================================== RCS file: /cvs/ecos/ecos/packages/hal/arm/pid/current/ChangeLog,v retrieving revision 1.33 diff -u -5 -p -r1.33 ChangeLog --- ChangeLog 15 Apr 2003 10:15:24 -0000 1.33 +++ ChangeLog 30 Apr 2003 13:22:49 -0000 @@ -1,5 +1,11 @@ +2003-04-30 Jonathan Larmour <jifl@eCosCentric.com> + + * cdl/hal_arm_pid.cdl: Make CYGBLD_GLOBAL_LDFLAGS depend on + CYGBLD_ARM_ENABLE_THUMB_INTERWORK instead of also + CYGSEM_HAL_ROM_MONITOR, redundantly. + 2003-04-11 Bart Veer <bartv@ecoscentric.com>

 	* cdl/hal_arm_pid.cdl: building for thumb now involves arm-elf-gcc
 	-mthumb, not thumb-elf-gcc

Index: cdl/hal_arm_pid.cdl
===================================================================
RCS file: /cvs/ecos/ecos/packages/hal/arm/pid/current/cdl/hal_arm_pid.cdl,v
retrieving revision 1.13
diff -u -5 -p -r1.13 hal_arm_pid.cdl
--- cdl/hal_arm_pid.cdl 15 Apr 2003 10:15:28 -0000 1.13
+++ cdl/hal_arm_pid.cdl 30 Apr 2003 13:22:50 -0000
@@ -242,11 +242,11 @@ cdl_package CYGPKG_HAL_ARM_PID {
cdl_option CYGBLD_GLOBAL_LDFLAGS {
display "Global linker flags"
flavor data
no_define
default_value { (CYGHWR_THUMB ? "-mthumb " : ((CYGHWR_HAL_ARM_CPU_FAMILY == "ARM9") ? "-mcpu=arm9 " : "-mcpu=arm7tdmi ")) .
- ((CYGBLD_ARM_ENABLE_THUMB_INTERWORK || CYGSEM_HAL_ROM_MONITOR) ? "-mthumb-interwork " : "") .
+ (CYGBLD_ARM_ENABLE_THUMB_INTERWORK ? "-mthumb-interwork " : "") .
(CYGHWR_HAL_ARM_BIGENDIAN ? "-mbig-endian " : "") .
"-g -nostdlib -Wl,--gc-sections -Wl,-static" }
description "
This option controls the global linker flags. Individual
packages may define options which override these global flags."


--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]