This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: important strataflash fix
- From: Gary Thomas <gary at mlbassoc dot com>
- To: jani at iv dot ro
- Cc: eCos patches <ecos-patches at sources dot redhat dot com>
- Date: 02 May 2003 10:34:12 -0600
- Subject: Re: important strataflash fix
- Organization: MLB Associates
- References: <20030502163742.GA25012@cow>
On Fri, 2003-05-02 at 10:37, jani@iv.ro wrote:
> Hi
>
> While doing the cleanup patches which removed cache handling from low level
> flash drivers I overlooked the fact that for flash_query the upper layer
> only handles caches if dev_flash_query is called. Since strata had it's
> own 'copy code to RAM and execute' it did not call flash_dev_query but I
> stupidly removed the cache enabling and disabling.
> So the cerfpda does not boot if flash support is enabled and a PXA with
> strataflash I am working with has the same problem but edb7xxx works.
> Here's a patch that converts strata to using flash_dev_query and fixes the
> breakage.
>
> /me goes to the blackboard and writes "If it ain't broken but you fix it
> at least fix it right!" several times
>
Thanks for [finding & fixing] this! I'll commit it right away.
--
Gary Thomas <gary@mlbassoc.com>
MLB Associates