Re: EB40a evaluation LEDs

[Jonathan Larmour <jifl at eCosCentric dot com>]

Andrew Lunn wrote:
> I changed the order of these, so that LED1 comes first....
>
> While i was at it, i also fixed one of the compiler warnings. One
> still remains.
>
> I don't have the hardware to test this on, but it does at least
> compile.

I don't have hardware here either. Nick does have an EB40a, but to be 
honest, I don't think in general we should rely on one person to test a 
patch as a prerequisite for committing otherwise the patch backlog will 
grow even quicker! Of course if Nick or someone else wants to test and 
report back, then the patch can easily be reverted if need be.

But I'm sure most people who write these patches do so for a reason and do 
test them! Probably not always, but hopefully enough.

Oh, and thanks Andrew for trying out the patch and getting it into a 
commitable state.

Jifl
--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine