This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] remove 32 MByte limit for RedBoot/tftp download


jeroen dobbelaere wrote:
Following patch allows you to download images bigger than 32 MByte with RedBoot, using tftp.
(well, only if the tftp server supports this ;) )

Seems fine apart from one thing:


+ if ((cyg_uint16) (ntohs(hdr->th_block)) == (cyg_uint16)((tftp_stream.last_good_block+1) & 0xFFFF)) {

The first cast isn't required because of course it's already a short.


Committed with that change, thanks!

BTW, I've written a ChangeLog entry for you this time but it would be nice not to need to :-).

Jifl
--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]