This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: IO/ETH: Fix NBPFILTER warnings
Gary Thomas <gary@mlbassoc.com> writes:
> On Wed, 2003-07-23 at 12:02, Nick Garnett wrote:
> <snip>
> > Index: src/net/eth_drv.c
> > ===================================================================
> > RCS file: /cvs/ecos/ecos/packages/io/eth/current/src/net/eth_drv.c,v
> > retrieving revision 1.27
> > diff -u -5 -r1.27 eth_drv.c
> > --- src/net/eth_drv.c 17 Mar 2003 18:37:21 -0000 1.27
> > +++ src/net/eth_drv.c 23 Jul 2003 18:00:59 -0000
> > @@ -71,10 +71,14 @@
> > #include <netinet/in_var.h>
> > #include <netinet/ip.h>
> > #include <netinet/if_ether.h>
> > #endif
> >
> =============================================================
> > +#ifndef NBPFILTER
> > +#define NBPFILTER 0
> > +#endif
> > +
> > #if NBPFILTER > 0
> > #include <net/bpf.h>
> > #include <net/bpfdesc.h>
> > #endif
> >
> ===============================================================
>
> It seems to me that these lines could just be removed [safely]
> since they also appear in the eth_drv.h file.
The eth_drv.h file is included somewhat later and I wasn't sure
whether there was method in including the bridge files earlier. To do
it before something gets defined in one of the other headers, for
example. The net stacks are very sensitive to that sort of thing, so I
decided to make the most conservative change in case I broke
something.
--
Nick Garnett eCos Kernel Architect
http://www.ecoscentric.com The eCos and RedBoot experts