This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Intel FLASH


> Looking at this a little more closely, I see that the only other place
> that CYGNUM_FLASH_BASE_MASK is used in my patched version of the
> driver is in'flash_program_buf()'.  Looking at that a little more
> closely, I just noticed that it is passed a 'block_mask' parameter,
> which is initialized to:
> 
> ~(flash_info.block_size-1)
> 
> in "io/flash/current/src/flash.c".  Why don't I change
> 'flash_program_buf()' to use this parameter and confine the use of
> this mask to the description given in "strata.h".  If folks would
> prefer that I use some name other'CYGNUM_FLASH_BASE_MASK' in order to
> capture the notion of fitting oversized devices in a platform.

Right, in program_buf instead of ROM using BA seems safe and indeed the
macro can now be used for the oversized devices.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]