This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: patch - at91 serial drivers assumed realtime response for DSRroutines
- From: Gary Thomas <gary at mlbassoc dot com>
- To: Jani Monoses <jani at iv dot ro>
- Cc: ecos-patches at sources dot redhat dot com
- Date: 21 Oct 2003 08:18:40 -0600
- Subject: Re: patch - at91 serial drivers assumed realtime response for DSRroutines
- Organization: MLB Associates
- References: <1066741018.22241.29.camel@famine> <20031021165832.4830a47a.jani@iv.ro>
On Tue, 2003-10-21 at 07:58, Jani Monoses wrote:
> > The at91 serial routines are broken in that they assume a very low
> > latency for the DSR handler.
>
> The patch you sent is specific to your setup right, it's not a clean
> update to at91 serial? I see hw flowcontrol and line status code is
> there but the at91 does not have such capabilities.
> I just mention this so that whoever else sees the patch knows that a
> patch which would just improve upon the current driver without the
> 16650 support would be smaller and cleaner :)
... and more likely to be accepted into the mainline sources.
Honestly, we have a hard enough time deciding how to handle patches
when they are concise and limited. Keeping them as simple and to the
point as possible makes everyone's life better. Also, if you have
more than one issue to address, send more than one patch.
--
Gary Thomas <gary@mlbassoc.com>
MLB Associates