This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New port for ARM Industrial Module AIM 711


Hi Roland

Thank you for the patch.

Roland Caßebohm wrote:

+target aim711 {
+ alias { "ARM Industrial Module AIM 711" AIM711 aim711 }
+ packages {
+ CYGPKG_HAL_ARM + CYGPKG_HAL_ARM_AIM711 + CYGPKG_DEVS_FLASH_ARM_AIM711
+ CYGPKG_DEVS_FLASH_SST_39VFXXX
+ CYGPKG_DEVS_ETH_ARM_KS32C5000
+ CYGPKG_IO_SERIAL_ARM_AIM711
+ CYGPKG_IO_SERIAL_ARM_S3C4510
+ CYGPKG_IO_SERIAL_ARM_AIM711_S3C4510
+ CYGPKG_IO_SERIAL_GENERIC_16X5X
+ CYGPKG_IO_SERIAL_ARM_AIM711_16X5X
+ CYGPKG_DEVICES_WALLCLOCK_ARM_AIM711
+ CYGPKG_DEVICES_WALLCLOCK_DALLAS_DS1307
+ }
+ enable CYGHWR_HAL_ARM_BIGENDIAN
+ disable CYGPKG_DEVS_ETH_ARM_KS32C5000_PHY_LXT970
+ enable CYGPKG_DEVS_ETH_ARM_KS32C5000_PHY_RTL8201
+ set_value CYGPKG_DEVS_ETH_ARM_KS32C5000_PHYADDR 2
+ description "
+ The aim711 target provides the packages needed to run eCos on a
+ ARM Industrial Module AIM 711."
}

The "enable", "disable" and "set_value" commands should be implemented as "requires" contraints in CYGPKG_HAL_ARM_AIM711 rather than in ecos.db. It is best to avoid these commands wherever possible since their implementation is not elegant. For example, the corresponding CDL options will be given a "user value" rather than an "inferred value".


I will leave comments on the run-time aspects to other maintainers.

John Dallaway
eCosCentric Limited
--
Visit us at Embedded Systems Conference :: San Francisco Mar 30-Apr 1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]