This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: fopen() w+ Fix
- From: "Gary Thomas" <gary at mlbassoc dot com>
- To: "Andrew Lunn" <andrew at lunn dot ch>
- Cc: "Kelvin Lawson" <klawson at ad-holdings dot co dot uk>,ecos-patches at sources dot redhat dot com
- Date: Mon, 29 Mar 2004 04:42:52 -0700 (MST)
- Subject: Re: fopen() w+ Fix
- References: <c48s9b$3p1$1@sea.gmane.org> <20040329112555.GA24325@lunn.ch>
Andrew Lunn said:
> On Mon, Mar 29, 2004 at 11:01:42AM +0100, Kelvin Lawson wrote:
>> Hi All,
>>
>> I've attached a proposed fix for fopen() with mode 'w+'. Basically
>> specifying 'w+' was previously exactly the same as specifying 'r+', but
>> 'w+' should allow file creation, while 'r+' should not.
>>
>> I've split CYG_STREAM_READWRITE into CYG_STREAM_READWRITE_CREATE and
>> CYG_STREAM_READWRITE_NOCREATE to allow for these different modes.
>
> Commited.
And you even fixed the indentation - hurray :-)
Note to patch submitters: please provide patches that follow the eCos
coding techniques we've used (at least as far as code indentation
within the same file!) The maintainers should not have to work over
the code before a patch is checked in. Thanks.