Re: in_cksum stats not handle by FreeBSD TPC/IP stack ?

[Gary Thomas <gary at mlbassoc dot com>]

On Fri, 2004-04-23 at 07:19, sebastien Couret wrote:
> Hi guys,
> I came across a link problem while using the Network statistics option 
> (CYGDBG_NET_TIMING_STATS) with FreeBSD stack.
> In fact "struct net_stats stats_in_cksum" is never instantiated by the 
> FreeBSD stacks as shown :
> 
> egrep -r stats_in_cksum /opt/ecos/packages/
> 
> /opt/ecos/packages/net/bsd_tcpip/current/src/ecos/support.c:
> extern struct net_stats stats_in_cksum;
> /opt/ecos/packages/net/bsd_tcpip/current/src/ecos/support.c:    
> show_net_stats(&stats_in_cksum,      "Checksum");
> 
> /opt/ecos/packages/net/tcpip/current/src/ecos/support.c:
> extern struct net_stats stats_in_cksum;
> /opt/ecos/packages/net/tcpip/current/src/ecos/support.c:    
> show_net_stats(&stats_in_cksum,    "Checksum");
> /opt/ecos/packages/net/tcpip/current/src/sys/netinet/in_cksum.c:
> struct net_stats stats_in_cksum;
> /opt/ecos/packages/net/tcpip/current/src/sys/netinet/in_cksum.c:        
> FINISH_STATS(stats_in_cksum);
> 
> In fact , stats_in_cksum is only instantiated and managed by the OpenBSD 
> stack in file net/tcpip/current/src/sys/netinet/in_cksum.c
> but nothing is done in his "FreeBSD twin" : 
> net/tcpip/current/src/sys/netinet/in_cksum.c 
> 
> My question is : Should we try to had such a support in 
> net/tcpip/current/src/sys/netinet/in_cksum.c ? or should in_cksum support be 
> removed from the FreeBSD stack ?

This was just some debug/profile information I added when first doing
the OpenBSD stack (now some 5 years ago).  It's not normally turned on
and leaving it in place at least leaves the indication of how to make
it work in future should someone else want to fine-tune the network
system.  I prefer to leave it in as-is.  If someone wants to bother
with adding the functions to the FreeBSD stack to make it work, feel
free.

-- 
Gary Thomas <gary@mlbassoc.com>
MLB Associates