This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
[Bug 1000096] new AT91 platform: JTST
- From: bugzilla at ecoscentric dot com
- To: ecos-patches at ecos dot sourceware dot org
- Date: Fri, 17 Sep 2004 12:56:57 +0100 (BST)
- Subject: [Bug 1000096] new AT91 platform: JTST
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000096
------- Additional Comments From andrew.lunn@ascom.ch 2004-17-09 12:56 -------
#define RUNMAGIC
HAL_WRITE_UINT32(AT91_MAARCSE+AT91_MAARCSE_CMD,AT91_MAARCSE_CMD_RUN);
+#define WAITSYSTEM jtst_wait_magic();
+
RUNMAGIC should really be HAL_RUNMAGIC, and WAITSYSTEM should be HAL_WAITSYSTEM.
Also jtst_wait_magic() would be better as cyg_hal_jtst_wait_magic(). These are
all name space polution issues. Some comments to what these do would also be good.
+#define ISP1181_IRQ_USB_SERVICE_REQUEST 24
Again, it does not fit the naming convention and its not clear what its for. Its
not used anywhere else in the code. Is it trying to say the USB is using
interrupt 24? If do i would call this something like
CYGNUM_HAL_INTERRUPT_ISP1181
+.macro __todo
+ ldr r0,=AT91_PIO
+ ldr r1,=BIT21|BIT22|BIT23|BIT24|BIT25|BIT26|BIT27|BIT3
+ str r1,[r0,#AT91_PIO_SODR] // set this bit must be always 1, otherwise resets
+ ldr r1,=BIT21|BIT22|BIT23|BIT24|BIT25|BIT26|BIT27|BIT3
+ str r1,[r0,#AT91_PIO_OER] // set to output
A better name for this macro would be good.
+#define CYGNUM_HAL_INTERRUPT_MAGICHLT 0
+
+#define CYGNUM_HAL_INTERRUPT_TIMER0 1
+#define CYGNUM_HAL_INTERRUPT_TIMER1 2
+#define CYGNUM_HAL_INTERRUPT_TIMER2 3
Does this use the same interrupt controller as the other at91 chips?
>From what i remember from reading a data sheet yesterday, interrupt 0 is for
the FIQ, and 1 is reserved? Does this chip do something different?
There are a few places where the white spacing looks wrong. Please could you
expand all tabs to spaces.
Like i said before, overall it looks good, just some minor issues to tidy up.
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.