This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: init_priority fix for services/memalloc
On Wed, 2004-09-29 at 13:51, Andrew Lunn wrote:
> On Wed, Sep 29, 2004 at 12:50:22PM +0200, ?yvind Harboe wrote:
> > Do you think we can get a consensus to at least commit these fixes as
> > they are found?
>
> The first sweep with grep and looking at all the hits should get 95%
> of them at least in the first go. Once that is commited fixing any
> others as they are found is OK. What i do not want to do is fix it one
> at a time from the beginning as people run into them.
>
> So if you submit a patch from the grep sweep i will look at it. I will
> reject your memalloc patch since this will be part of your bigger
> patch.
Hmmm.... how do I grep?
I guess I have to manually examine every single instance of
CYGBLD_ATTRIB_INIT_PRI manually. The problem with writing a regex is
.tcl scripts and preprocessing...
Also, I need to write a couple of test cases to ensure that I'm looking
for the right thing.
I believe
static foo bar CYGBLD_ATTRIB_INIT_PRI(N); // ok
static foo bar(5) CYGBLD_ATTRIB_INIT_PRI(N); // not ok
static foo CYGBLD_ATTRIB_INIT_PRI(N) bar(5) ; // ok
static foo bar CYGBLD_ATTRIB_INIT_PRI(N)=new foo(5); // ok
>
> Andrew
--
Øyvind Harboe
http://www.zylin.com