This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC 1877 (IPCP Extensions for DNS)


Andrew,

Your changes look good.  I tested them out and found a
few minor issues.
1) The #ifdef in sys-ecos.c had a typo that prevented
it from ever being included.
2) Verify the DNS address was non-zero before invoking
cyg_dns_res_init.
3) Pass in the address of the dns_addr[0] rather than
the value.

The attached patch has the corrections.  You can diff
your patch and mine to see exactly what I'm talking
about.

Thanks for your help on this,
-- Matt

--- Andrew Lunn <andrew@lunn.ch> wrote:

> I've worked on this some more. Attached is what i
> think would be
> good. You function has stayed, but i've also added
> code to configure
> the resolver. This controlled by CDL. 
> 
> I don't have a PPP setup to test this with, so it
> would be good if you
> could test it please and let me know if it works,
> along with any other
> comments you have.
>         
>         Thanks
>                 Andrew

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Attachment: ppp_ns_1.diff
Description: 2356664992-ppp_ns_1.diff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]