This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: [PATCH] move cyg_posix_function_start() and _finish() from misc.cxx to pthread.cxx
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Alexander Neundorf <neundorf at kde dot org>
- Cc: ecos-patches at ecos dot sourceware dot org
- Date: Thu, 27 Oct 2005 20:59:43 +0200
- Subject: Re: [PATCH] move cyg_posix_function_start() and _finish() from misc.cxx to pthread.cxx
- References: <200510262122.09969.neundorf@kde.org>
On Wed, Oct 26, 2005 at 09:22:09PM +0200, Alexander Neundorf wrote:
> Hi,
>
> the functions cyg_posix_function_start() and _finish() from
> compat/posix/current/src/misc.cxx deal with ASR handling and nothing else.
> From checking the eCos code it seems the only two files which use ASRs are
> pthread.cxx and signal.cxx in the POSIX package.
You missed that the fileio package makes use of them.
> So IMO cyg_posix_function_start() and _finish() should be moved to
> pthread.cxx, so that they are only compiled and used if they are actually
> required.
They are currently only used if actually required. The linker will
only pull them into the image if something calls them. So i don't
really see the point of the patch. It does not make the image smaller
and it does not aid maintainability.
Andrew