This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: Generic 8250 serial diagnostics.
- From: Andrew Lunn <andrew at lunn dot ch>
- To: David Vrabel <dvrabel at arcom dot com>
- Cc: eCos Patches <ecos-patches at ecos dot sourceware dot org>
- Date: Thu, 29 Dec 2005 11:23:38 +0100
- Subject: Re: Generic 8250 serial diagnostics.
- References: <43A6D460.4060006@arcom.com>
On Mon, Dec 19, 2005 at 03:40:16PM +0000, David Vrabel wrote:
> Hi,
>
> The patches adds generic 8250/16x50 serial diagnostics routines to
> hal/common. It's been tested with standard PC UARTs, IXP4xx internal
> UARTs, and external UARTs on a PXA270 board. It likely works for many
> other processor/UART combinations.
>
> I think this is preferable to the current practice of copying all the
> routines whenever a new platform is implemented.
>
> UART quirks (e.g., the UUE bit on the internal UARTs of the IXP4xx) are
> handled by a set of UART_FEATURE_XXX bits which are provided on a
> per-port basis. Additional UART quirks can be added as required.
Hi David
I like the idea, but not the location. I don't think this belongs in
the hal/common directory.
How about
devs/serial/generic/16x5x-haldiag
Andrew