This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: Incomplete baud rate mapping in termiostty.c
- From: Jonathan Larmour <jifl at eCosCentric dot com>
- To: Jay Foster <jay at systech dot com>
- Cc: 'Andrew Lunn' <andrew at lunn dot ch>, Rainer Arndt <Arndt-ADT at kieback-peter dot de>, ecos-patches at ecos dot sourceware dot org
- Date: Wed, 05 Mar 2008 16:05:43 +0000
- Subject: Re: Incomplete baud rate mapping in termiostty.c
- Openpgp: id=A5FB74E6
- References: <74C9525D67A5FF4791614FDB06593BB10429A475@mail.systech.com>
Jay Foster wrote:
> Should the setting of priv->init = true be dependent on the return value of
> real_termios_init()?
>
> res = real_termios_init();
> if (ENOERR == res)
> priv->init = true;
>
> Or maybe it doesn't matter.
Probably better to ignore the return value so the device can be retried on
subsequent calls - the only relevant failure mode is in retrieving the
config and maybe it was a transient error.
Jifl
--
eCosCentric Limited http://www.eCosCentric.com/ The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["Si fractum non sit, noli id reficere"]------ Opinions==mine