This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
RE: Consolidation of MPC555 serial drivers
- From: "Steven Clugston" <steven dot clugston at newcastle dot ac dot uk>
- To: "ecos-patches" <ecos-patches at ecos dot sourceware dot org>
- Date: Wed, 7 May 2008 14:55:08 +0100
- Subject: RE: Consolidation of MPC555 serial drivers
>-----Original Message-----
>From: Andrew Lunn [mailto:andrew@lunn.ch]
>Sent: 06 May 2008 20:06
>To: Steven Clugston
>Cc: ecos-patches
>Subject: Re: Consolidation of MPC555 serial drivers
>
>
>On Tue, May 06, 2008 at 03:36:48PM +0100, Steven Clugston wrote:
>> As discussed on ecos-discuss, I've tried to consolidate the
>two mpc555
>> serial drivers for the ec555 and cme555 which are functionally
>> identical. I've attached the diff and a tar of the affected files.
>>
>> This change will help me to address some possible bugs and new
>> functionality which would be common to both.
>>
>> Hope the diff is ok, if not please advise and I'll try and sort it
>> out.
>
>Actually, i could not get the diff to apply at all. So i did
>it all by hand. It compiles O.K, but it would be good it you
>can test what is in CVS.
>
> Thanks
> Andrew
>
I've done a fresh chechout from cvs and managed to build the default
template for both ec555 and cme555 with the hardware serial driver cdl
option enabled.
I don't have either a ec555 or cme555 to test that it works on the
board, but I can't see why it wouldn't but I will be testing it with my
mpc555 target fairly soon just in case.
Sorry about the diff file, I don't normally have much cause to use them
so I'm a bit of a novice with them.
Just for future reference how do you normally create diffs suitable for
submission to ecos-patches?
I checked out a fresh copy of ecos from cvs to a directory then made a
copy of that directory to to which I made the changes, then I ran diff
on the two directories (using Kompare) to generate the diff file. I
think at least one problem was that I ran it on the actual outer
directories and not just the ecos/ subfolder within them.
Is there a way to do a diff with an ecos source tree directly against
cvs?
Thanks
Steven