This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1000788] This patch adds macros to unmask & acknowledge gpio interrupts.


http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000788


vibi <vibi_sreenivasan@cms.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vibi_sreenivasan@cms.com




--- Comment #2 from vibi <vibi_sreenivasan@cms.com>  2009-06-16 08:00:16 ---
Hi Andrew,
     Thanks for looking into this patch.
(In reply to comment #1)
> This patch needs a bit of a re-think.
I am sorry, i was terribly wrong in posting this patch without thinking much.

> 
> You need to be able to unmask and mask an interrupt from a GPIO pin. So it
> would be better if the macro took an enable/disable or mask/unmask parameter
> and then set a bit in IER or IDR.

What ever i have done is wrong , IMR is a readonly register.
Every thing can be  done with the existing infra structure.
> 
> You ACK macro makes no sense. You cannot ACK a specific pin. What you have to
> do is read the interrupt status for a PIO port, ie 32 pins and then determine
> if your pin of interest has generated an interrupt. I cannot think of a way to
> do this with macros which is portable across different AT91SAM devices. You
> have to write some C code which is specific to your platform.
> 
Thanks again for spending your time.

Thanks & Regards
vibi sreenivasan


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]