This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: [PATCH] stm32 uart: use 16bit register access
Spencer Oliver <spen@spen-soft.co.uk> writes:
> On 17/05/2010 12:10, Nick Garnett wrote:
> > Was there a specific reason you wanted to use 16 bit accesses rather
> > than 32 bit?
> >
>
> I was getting a Access Fault when testing, changing to use 16bit
> access cured the problem for me.
> This was when the Enable Usage, Bus and Mem fault handlers were
> enabled in hal_reset_vsr.
Very odd. In theory these registers should be quite safe for all types
of access.
>
> Looking at reference code from the stm32lib shows all the accesses
> as 16bit.
I think if we already had 16 bit accesses we wouldn't change them to
32 bit. But there seems little real need to go the other way either.
>
> Oh well, just rebuilt all and working fine now :)
>
OK, I think we should just leave things as they are for now. If you
come across it again and find compelling evidence to change then we
can revisit it.
--
Nick Garnett eCos Kernel Architect
eCosCentric Limited http://www.eCosCentric.com The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571
Registered in England and Wales: Reg No: 4422071