This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

src/gdb ChangeLog ada-valprint.c c-valprint.c


CVSROOT:	/cvs/src
Module name:	src
Changes by:	brobecke@sourceware.org	2011-01-14 19:32:57

Modified files:
	gdb            : ChangeLog ada-valprint.c c-valprint.c 

Log message:
	Fix printing of Wide_Character & Wide_Wide_Character entities.
	
	Wide_Characters and Wide_Wide_Characters are incorrectly printed.
	Consider for instance:
	
	Medium : Wide_Character := Wide_Character'Val(16#dead#);
	
	Trying to print the value of this variable yields:
	
	(gdb) p medium
	$1 = 57005 '["ad"]'
	
	The integer value is correct (57005 = 0xdead), but the character
	representation is not, it should be:
	
	$1 = 57005 '["dead"]'
	
	Same for Wide_Wide_Characters.
	
	There were two issues:
	(a) The first issue was in ada-valprint, where we were assuming
	that character types were 1 byte long;
	(b) The second problem was in c-valprint, where we were down-casting
	the integer value of the character to type `unsigned char',
	causing use to lose all but the lowest byte.
	
	gdb/ChangeLog:
	
	* ada-valprint. (ada_printchar): Use the correct type length
	in call to ada_emit_char.
	* c-valprint.c (c_val_print): Remove cast in call to LA_PRINT_CHAR.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.12482&r2=1.12483
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ada-valprint.c.diff?cvsroot=src&r1=1.73&r2=1.74
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/c-valprint.c.diff?cvsroot=src&r1=1.78&r2=1.79


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]