src/gdb ChangeLog frame.c printcmd.c record-fu ...

[palves at sourceware dot org]

CVSROOT:	/cvs/src
Module name:	src
Changes by:	palves@sourceware.org	2013-04-10 15:11:12

Modified files:
	gdb            : ChangeLog frame.c printcmd.c record-full.c 
	                 record.c ser-tcp.c source.c top.c tracepoint.c 
	                 utils.c valprint.c 
	gdb/cli        : cli-decode.c cli-setshow.c 
	gdb/doc        : ChangeLog gdb.texinfo 
	gdb/testsuite  : ChangeLog 
	gdb/testsuite/gdb.base: completion.exp setshow.exp 
	gdb/testsuite/gdb.trace: trace-buffer-size.exp 

Log message:
	Accept "set foo unlimited" in integer/uinteger/zuinteger_unlimited commands.
	
	Currently, several commands take "0" or "-1" to mean "unlimited".
	
	"show" knows when to print "unlimited":
	
	(gdb) show height
	Number of lines gdb thinks are in a page is 45.
	(gdb) set height 0
	(gdb) show height
	Number of lines gdb thinks are in a page is unlimited.
	
	However, the user can't herself specify "unlimited" directly:
	
	(gdb) set height unlimited
	No symbol table is loaded.  Use the "file" command.
	(gdb)
	
	This patch addresses that, by adjusting the set handler for all
	integer/uinteger/zuinteger_unlimited commands to accept literal
	"unlimited".  It also installs a completer.  Presently, we complete on
	symbols by default, and at
	<http://sourceware.org/ml/gdb-patches/2013-03/msg00864.html> I've
	shown a WIP prototype that tried to keep that half working in these
	commands.  In the end, it turned out to be more complicated than
	justifiable, IMO.  It's super rare to want to pass the value of a
	variable/symbol in the program to a GDB set/show knob.  That'll still
	work, it's just that we won't assist with completion anymore.  This
	patch just sticks with the simple, and completes on "unlimited", and
	nothing else.  This simplification means that
	
	"set he<tab><tab>"
	
	is all it takes to get to:
	
	"set height unlimited"
	
	The patch then goes through all integer/uinteger/zuinteger_unlimited
	commands in the tree, and updates both the online help and the manual
	to mention that "unlimited" is accepted in addition to 0/-1.  In the
	cases where the command had no online help text at all, this adds it.
	I've tried to make the texts read in a way that "unlimited" is
	suggested before "0" or "-1" is.
	
	Tested on x86_64 Fedora 17.
	
	gdb/
	2013-04-10  Pedro Alves  <palves@redhat.com>
	
	* cli/cli-decode.c (integer_unlimited_completer): New function.
	(add_setshow_integer_cmd, add_setshow_uinteger_cmd)
	(add_setshow_zuinteger_unlimited_cmd): Install the "unlimited"
	completer.
	* cli/cli-setshow.c: Include "cli/cli-utils.h".
	(is_unlimited_literal): New function.
	(do_set_command): Handle literal "unlimited" arguments.
	* frame.c (_initialize_frame) <set backtrace limit>: Document
	"unlimited".
	* printcmd.c (_initialize_printcmd) <set print
	max-symbolic-offset>: Add help text.
	* record-full.c (_initialize_record_full) <set record full
	insn-number-max>: Likewise.
	* record.c (_initialize_record) <set record
	instruction-history-size, set record function-call-history-size>:
	Add help text.
	* ser-tcp.c (_initialize_ser_tcp) <set tcp connect-timeout>: Add
	help text.
	* tracepoint.c (_initialize_tracepoint) <set trace-buffer-size>:
	Likewise.
	* source.c (_initialize_source) <set listsize>: Add help text.
	* utils.c (initialize_utils) <set height, set width>: Likewise.
	<set pagination>: Mention "set height unlimited".
	* valprint.c (_initialize_valprint) <set print elements, set print
	repeats>: Document "unlimited".
	
	gdb/doc/
	2013-04-10  Pedro Alves  <palves@redhat.com>
	
	* gdb.texinfo (Process Record and Replay): Document that "set
	record full insn-number-max", "set record
	instruction-history-size" and "set record
	function-call-history-size" accept "unlimited".
	(Backtrace): Document that "set backtrace limit" accepts
	"unlimited".
	(List): Document that "set listsize" accepts "unlimited".
	(Print Settings)" Document that "set print max-symbolic-offset",
	"set print elements" and "set print repeats" accept "unlimited".
	(Starting and Stopping Trace Experiments): Document that "set
	trace-buffer-size" accepts "unlimited".
	(Remote Configuration): Document that "set tcp connect-timeout"
	accepts "unlimited".
	(Command History): Document that "set history size" accepts
	"unlimited".
	(Screen Size): Document that "set height" and "set width" accepts
	"unlimited".  Adjust "set pagination"'s description to suggest
	"set height unlimited" instead of "set height 0".
	
	gdb/testsuite/
	2013-04-10  Pedro Alves  <palves@redhat.com>
	
	* gdb.base/completion.exp: Test "set height", "set listsize" and
	"set trace-buffer-size" completion.
	* gdb.base/setshow.exp: Test "set height unlimited".
	* gdb.trace/trace-buffer-size.exp: Test "set trace-buffer-size
	unlimited".

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.15393&r2=1.15394
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/frame.c.diff?cvsroot=src&r1=1.316&r2=1.317
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/printcmd.c.diff?cvsroot=src&r1=1.228&r2=1.229
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/record-full.c.diff?cvsroot=src&r1=1.6&r2=1.7
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/record.c.diff?cvsroot=src&r1=1.85&r2=1.86
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ser-tcp.c.diff?cvsroot=src&r1=1.44&r2=1.45
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/source.c.diff?cvsroot=src&r1=1.156&r2=1.157
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/top.c.diff?cvsroot=src&r1=1.232&r2=1.233
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/tracepoint.c.diff?cvsroot=src&r1=1.299&r2=1.300
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=src&r1=1.296&r2=1.297
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/valprint.c.diff?cvsroot=src&r1=1.135&r2=1.136
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cli/cli-decode.c.diff?cvsroot=src&r1=1.117&r2=1.118
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/cli/cli-setshow.c.diff?cvsroot=src&r1=1.60&r2=1.61
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/doc/ChangeLog.diff?cvsroot=src&r1=1.1439&r2=1.1440
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/doc/gdb.texinfo.diff?cvsroot=src&r1=1.1073&r2=1.1074
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.3621&r2=1.3622
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/completion.exp.diff?cvsroot=src&r1=1.67&r2=1.68
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.base/setshow.exp.diff?cvsroot=src&r1=1.28&r2=1.29
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.trace/trace-buffer-size.exp.diff?cvsroot=src&r1=1.3&r2=1.4