This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. 6b6aa828818fa4a5754fb8520751077146d9d16c
- From: qiyao at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 24 Jan 2014 13:36:10 -0000
- Subject: gdb and binutils branch master updated. 6b6aa828818fa4a5754fb8520751077146d9d16c
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 6b6aa828818fa4a5754fb8520751077146d9d16c (commit)
via 5d6df423905215fc5ef796f20525cd84f92c3a8e (commit)
from d9d94ac86ba0193c897d1fc80b551996ae959d50 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6b6aa828818fa4a5754fb8520751077146d9d16c
commit 6b6aa828818fa4a5754fb8520751077146d9d16c
Author: Yao Qi <yao@codesourcery.com>
Date: Fri Jan 10 14:11:59 2014 +0800
Change len's type to ULONGEST: remote_read_bytes and get_core_siginfo
Functions remote_read_bytes and get_core_siginfo are the callees of
target to_xfer_partial interface, so argument 'len' should be changed
to type ULONGEST.
gdb:
2014-01-24 Yao Qi <yao@codesourcery.com>
* remote.c (remote_read_bytes): Change type of len to ULONGEST.
* corelow.c (get_core_siginfo): Likewise.
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5d6df423905215fc5ef796f20525cd84f92c3a8e
commit 5d6df423905215fc5ef796f20525cd84f92c3a8e
Author: Yao Qi <yao@codesourcery.com>
Date: Fri Jan 10 13:59:26 2014 +0800
Change len's type to ULONGEST: remote_write_bytes_aux
Hi,
This patch changes the type of 'len' from ssize_t to ULONGEST.
At the beginning Siddhesh Poyarekar proposed this patch
[PATCH] Memory reads and writes should have size_t length
https://sourceware.org/ml/gdb-patches/2012-05/msg01073.html
to change type of 'len' to size_t. However, after Jan's review, we
decide to change it to ssize_t, because callers of these functions
may pass signed type to them.
AFAICS, the target layer is a boundary. In one side, we pass size_t
or ssize_t to target related APIs, and in the other side, the
implementation side, we used LONGEST (ULONGEST in latest code) because
of to_xfer_partial.
Since remote_write_bytes_aux and remote_write_bytes belong to the
implementation of remote target, we should use ULONGEST for len, IMO.
Regression tested on x86_64-linux. Is it OK?
gdb:
2014-01-24 Yao Qi <yao@codesourcery.com>
* remote.c (remote_write_bytes_aux): Change type of 'len' to
ULONGEST. Don't check 'len' is negative.
(remote_write_bytes): Change type of 'len' to ULONGEST.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 11 +++++++++++
gdb/corelow.c | 2 +-
gdb/remote.c | 10 +++++-----
3 files changed, 17 insertions(+), 6 deletions(-)
hooks/post-receive
--
gdb and binutils