This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

gdb and binutils branch master updated. c4e54771f84f3acd02c6da80a6f62603eb3e8505


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  c4e54771f84f3acd02c6da80a6f62603eb3e8505 (commit)
      from  8832e7e38ec3596b4e584cfadca060567a7e8bc3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c4e54771f84f3acd02c6da80a6f62603eb3e8505

commit c4e54771f84f3acd02c6da80a6f62603eb3e8505
Author: Tom Tromey <tromey@redhat.com>
Date:   Mon May 19 13:10:21 2014 -0600

    fix two latent type errors
    
    I'm checking this in as obvious.
    
    I was looking at instances of "alloc.*sizeof" and noticed a couple
    where the types in question are incorrect.
    
    In gdbtypes, the code allocates sizeof(int) to represent a struct rank.
    In mi-cmds, the code uses "struct mi_cmd **" -- one "*" too many.
    
    In both cases the problems are latent because in practice the sizes
    are the same as the sizes of the correct types.  Still, it's better to
    be correct.
    
    I think gdb would be improved by a wholesale change from explicit
    sizeofs to using the libiberty.h allocation macros.  In most cases
    they are both shorter and have better type safety.  However, the
    resulting patch is rather large.
    
    Built and regtested on x86-64 Fedora 20.
    
    2014-05-19  Tom Tromey  <tromey@redhat.com>
    
    	* gdbtypes.c (rank_function): Use XNEWVEC.
    	* mi/mi-cmds.c (build_table): Use XCNEWVEC.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog    |    5 +++++
 gdb/gdbtypes.c   |    2 +-
 gdb/mi/mi-cmds.c |    4 +---
 3 files changed, 7 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
gdb and binutils


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]