gdb and binutils branch master updated. 8b696e31551d5cc7a3a01637c0a8d8246814a962

[qiyao at sourceware dot org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  8b696e31551d5cc7a3a01637c0a8d8246814a962 (commit)
       via  73c9764f95f3a06a11948c0a88dacc6e3ebcb660 (commit)
      from  f2205de0080d999c9b67872c9db471c31b53e378 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8b696e31551d5cc7a3a01637c0a8d8246814a962

commit 8b696e31551d5cc7a3a01637c0a8d8246814a962
Author: Yao Qi <yao@codesourcery.com>
Date:   Fri May 9 15:06:12 2014 +0800

    Set timeout for gdb.reverse/*.exp test cases
    
    Hi,
    This patch is to add a new board setting gdb_reverse_timeout, which is
    used to set timeout for all gdb.reverse test cases, which are usually
    very slow and cause some TIMEOUT failures, for example, on some arm
    boards.  We have some alternatives to this approach, but I am not
    satisfied with them:
    
     - Increase the timeout value.  This is the global change, and it may
       cause some delay where actual failures happen.
     - Set timeout by gdb_reverse_timeout in every gdb.reverse/*.exp.
       Then, we have to touch every file under gdb.reverse.
    
    In this patch, we choose a central place to set timeout for all tests
    in gdb.reverse, which is convenient.
    
    gdb/testsuite:
    
    2014-05-20  Yao Qi  <yao@codesourcery.com>
    
    	* lib/gdb.exp (gdb_init): Set timeout if test file is under
    	gdb.reverse directory and gdb_reverse_timeout exists in board
    	setting.
    	* README: Document gdb_reverse_timeout.

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=73c9764f95f3a06a11948c0a88dacc6e3ebcb660

commit 73c9764f95f3a06a11948c0a88dacc6e3ebcb660
Author: Yao Qi <yao@codesourcery.com>
Date:   Fri May 9 11:01:07 2014 +0800

    gdb_init argument ARGS is a string rather than a list
    
    The argument ARGS of gdb_init is passed from dejagnu is a string, the
    test file name.  In dejagnu/runtest.exp:
    
    proc runtest { test_file_name } {
    ....
    ....
            if [info exists tool] {
                if { [info procs "${tool}_init"] != "" } {
                    ${tool}_init $test_file_name;
                }
            }
    ....
    }
    
    but inn default_gdb_init (callee of gdb_init), we have
    
        set gdb_test_file_name [file rootname [file tail [lindex $args 0]]]
    
    In tcl, all actual arguments are combined to a list and assigned to
    args.  This code here isn't wrong, but unnecessary, because its caller
    (proc runtest) only passes one string to it, and IMO, we don't need
    such tricky tcl "args".
    
    I doubt that "[lindex $args 0]" is to be backward compatible with old
    dejagnu, but dejagnu-1.4 release started to pass $test_file_name to
    ${too}_init, as I showed above.  dejagnu-1.4 was released in 2001, and
    it should be old enough.  I also tried to check whether gdb testusite
    works with dejagnu-1.3 or not, but failed to build dejagnu-1.3 on my
    machine.  Supposing GDB testsuite requires at least dejagnu-1.4, this
    change should be safe.
    
    This patch is update default_gdb_init to treat ARGS as a string instead
    of a list.  Then, 'args' sounds like a list, and this patch also renames
    it by 'test_file_name', to align with dejagnu.
    
    gdb/testsuite:
    
    2014-05-20  Yao Qi  <yao@codesourcery.com>
    
    	* lib/gdb.exp (default_gdb_init): Rename argument 'args' by
    	'test_file_name'.  Treat args as a string instead of a list.
    	(gdb_init): Rename argument 'args' by 'test_file_name'.

-----------------------------------------------------------------------

Summary of changes:
 gdb/testsuite/ChangeLog   |   13 +++++++++++++
 gdb/testsuite/README      |    9 +++++++++
 gdb/testsuite/lib/gdb.exp |   21 +++++++++++----------
 3 files changed, 33 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
gdb and binutils