This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

gdb and binutils branch master updated. 41e995687391695e16550eb9c18da8e5d0dcffa9


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  41e995687391695e16550eb9c18da8e5d0dcffa9 (commit)
      from  487d975399dfcb2bb2f0998a7d12bd62acdd9fa1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=41e995687391695e16550eb9c18da8e5d0dcffa9

commit 41e995687391695e16550eb9c18da8e5d0dcffa9
Author: Pedro Alves <palves@redhat.com>
Date:   Tue Jul 15 17:30:34 2014 +0100

    gdb.base/reread.exp: Really restart GDB
    
    The other day I noticed that default_gdb_start reuses the GDB process
    if it has been spawned already:
    
    proc default_gdb_start { } {
    ...
        if [info exists gdb_spawn_id] {
    	return 0
        }
    
    I was a bit surprised, and so I hacked in an error to check whether
    anything is relying on it:
    
     + if [info exists gdb_spawn_id] {
     +    error "GDB already spawned"
     + }
    
    And lo, that tripped on a funny buglet (see below).  The comment in
    reread.exp says "Restart GDB entirely", but in reality, due to the
    above, that's not what is happening, as a gdb_exit call is missing.
    The test is proceeding with the previous GDB process...
    
    I don't really want to go hunt for whether there's an odd setup out
    there that assumes this in its board file or something, so for now,
    I'm taking the simple route of just making the test do what it says it
    does.  I think this much makes it an obvious fix.
    
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     (gdb) PASS: gdb.base/reread.exp: run to foo() second time
     ERROR: tcl error sourcing ../src/gdb/testsuite/gdb.base/reread.exp.
     ERROR: GDB already spawned
         while executing
     "error "GDB already spawned""
         invoked from within
     "if [info exists gdb_spawn_id] {
    	 error "GDB already spawned"
         }"
         (procedure "default_gdb_start" line 22)
         invoked from within
     "default_gdb_start"
         (procedure "gdb_start" line 2)
         invoked from within
     "gdb_start"
         invoked from within
     "if [is_remote target] {
         unsupported "second pass: GDB should check for changes before running"
     } else {
    
         # Put the older executable back in pl..."
         (file "../src/gdb/testsuite/gdb.base/reread.exp" line 114)
         invoked from within
     "source ../src/gdb/testsuite/gdb.base/reread.exp"
         ("uplevel" body line 1)
         invoked from within
     "uplevel #0 source ../src/gdb/testsuite/gdb.base/reread.exp"
         invoked from within
     "catch "uplevel #0 source $test_file_name""
     testcase ../src/gdb/testsuite/gdb.base/reread.exp completed in 1 seconds
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    gdb/testsuite/
    2014-07-15  Pedro Alves  <palves@redhat.com>
    
    	* gdb.base/reread.exp: Use clean_restart.

-----------------------------------------------------------------------

Summary of changes:
 gdb/testsuite/ChangeLog           |    4 ++++
 gdb/testsuite/gdb.base/reread.exp |    4 +---
 2 files changed, 5 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
gdb and binutils


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]