This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
gdb and binutils branch master updated. 72fde3dfe9a2367abc593684b9b4d2343d367d85
- From: brobecke at sourceware dot org
- To: gdb-cvs at sourceware dot org
- Date: 9 Sep 2014 15:01:46 -0000
- Subject: gdb and binutils branch master updated. 72fde3dfe9a2367abc593684b9b4d2343d367d85
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".
The branch, master has been updated
via 72fde3dfe9a2367abc593684b9b4d2343d367d85 (commit)
from d7adf9603ba5cdc21b88c6e2c0127f041a3320c8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=72fde3dfe9a2367abc593684b9b4d2343d367d85
commit 72fde3dfe9a2367abc593684b9b4d2343d367d85
Author: Joel Brobecker <brobecker@adacore.com>
Date: Tue Sep 9 16:49:13 2014 +0200
Fix missing "struct iovec" definition on some x86-linux.
The following patch...
commit 3116063bd617de56fbc3bad046a692b1fb363a9d
Date: Fri Jun 27 09:52:29 2014 +0100
Subject: Tidy #include lists
... introduced a build failure on certain x86 GNU/Linux distributions
(reproduced on SuSE 10 and RHES4) due to "struct iovec" not being
defined. This struct is defined in <sys/uio.h>, which used to be
explicitly included, but no longer is after the commit above was
applied.
[...]/i386-linux-nat.c: In function 'fetch_xstateregs':
[...]/i386-linux-nat.c:325:16: error: storage size of 'iov' isn't known
[...]/i386-linux-nat.c: In function 'store_xstateregs':
[...]/i386-linux-nat.c:348:16: error: storage size of 'iov' isn't known
make[2]: *** [i386-linux-nat.o] Error 1
It seems to be working on newer GNU/Linux distros thanks to indirect
inclusion of <sys/uio.h>, but it does not work on some other versions
of the same distros. This is why indirect includes of public APIs
should be avoided if at all possible.
This patch fixes the issue by adding the explicit include back.
gdb/ChangeLog:
* i386-linux-nat.c, x86-linux-nat.c: Add <sys/uio.h> #include.
-----------------------------------------------------------------------
Summary of changes:
gdb/ChangeLog | 4 ++++
gdb/i386-linux-nat.c | 1 +
gdb/x86-linux-nat.c | 1 +
3 files changed, 6 insertions(+), 0 deletions(-)
hooks/post-receive
--
gdb and binutils