This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

gdb and binutils branch master updated. 563e8d85161198df8a13de4bc660a047305458c9


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  563e8d85161198df8a13de4bc660a047305458c9 (commit)
       via  0ea4d52e4396f6fdf44e6b0d5a21db17cad41ec7 (commit)
      from  6041179a7496602f881b6f0a8c0bc3a8f1742cb7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=563e8d85161198df8a13de4bc660a047305458c9

commit 563e8d85161198df8a13de4bc660a047305458c9
Author: Yao Qi <yao@codesourcery.com>
Date:   Wed Oct 29 21:43:05 2014 +0800

    Prepare directory in case test_system fails
    
    In gdb.base/fileio.c, some functions may depend on others.  For
    example, test_rename renames a file to one directory which is created
    in test_system.  That is means, if test_system fails, test_rename
    fails too, which is not a good practise, IMO.
    
    In test_system, system ("mkdir -p XX") is used to create directories
    needed for test_rename.  In this patch, we use dejagnu remote_exec
    proc to create these directories on host.
    
    In my gdb testing, mingw32 host and arm-none-eabi target, system
    ("mkdir -p XX") doesn't work properly (this issue can be addressed
    separately), and this patch fixes the following fails.
    
    FAIL: gdb.base/fileio.exp: Renaming a directory to a non-empty directory returns ENOTEMPTY or EEXIST
    FAIL: gdb.base/fileio.exp: Unlink a file
    FAIL: gdb.base/fileio.exp: Unlinking a file in a directory w/o write access returns EACCES
    
    gdb/testsuite:
    
    2014-10-29  Yao Qi  <yao@codesourcery.com>
    
    	* gdb.base/fileio.exp: Make directories on host.

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0ea4d52e4396f6fdf44e6b0d5a21db17cad41ec7

commit 0ea4d52e4396f6fdf44e6b0d5a21db17cad41ec7
Author: Yao Qi <yao@codesourcery.com>
Date:   Wed Oct 29 21:43:05 2014 +0800

    Close the file in fileio.exp test
    
    I see the following fail in fileio.exp on mingw32 host gdb,
    
    rename 1: ret = -1, errno = 13^M
    ^M
    Breakpoint 2, stop () at fileio.c:76^M
    76      static void stop () {}^M
    (gdb) FAIL: gdb.base/fileio.exp: Rename a file
    
    the test fails to rename a file which is not expected.  The previous
    test test_write doesn't close the file, so the rename fails as a
    result on Windows.  This patch fixes it by closing file in test_write,
    and the fail goes away.
    
    rename 1: ret = 0, errno = 0 OK^M
    ^M
    Breakpoint 2, stop () at fileio.c:76^M
    76      static void stop () {}^M
    (gdb) PASS: gdb.base/fileio.exp: Rename a file
    
    gdb/testsuite:
    
    2014-10-29  Yao Qi  <yao@codesourcery.com>
    
    	* gdb.base/fileio.c (test_write): Close the file.

-----------------------------------------------------------------------

Summary of changes:
 gdb/testsuite/ChangeLog           |    8 ++++++++
 gdb/testsuite/gdb.base/fileio.c   |    1 +
 gdb/testsuite/gdb.base/fileio.exp |    7 +++++++
 3 files changed, 16 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
gdb and binutils


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]