This is the mail archive of the
gdb-cvs@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Fix '--target_board=native-extended-gdbserver/-m32'
- From: Pedro Alves <palves at sourceware dot org>
- To: gdb-cvs at sourceware dot org
- Date: 4 Feb 2015 13:54:01 -0000
- Subject: [binutils-gdb] Fix '--target_board=native-extended-gdbserver/-m32'
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=42d9e5288b6576b56f3f803901433b88ee863bc6
commit 42d9e5288b6576b56f3f803901433b88ee863bc6
Author: Pedro Alves <palves@redhat.com>
Date: Wed Feb 4 14:53:24 2015 +0100
Fix '--target_board=native-extended-gdbserver/-m32'
Running the testsuite with the native-extended-gdbserver.exp board and
passing a variant spec, like
make check RUNTESTFLAGS="--target_board=native-extended-gdbserver/-m32"
results in dejagnu trying to open a rsh connection to
"native-extended-gdbserver", which of course is wrong. The point of
this board is running things locally.
The issue is that the native-extended-gdbserver board does not clear
the "isremote" flag properly.
Reported by Sergio at:
https://sourceware.org/ml/gdb-patches/2015-02/msg00067.html
testsuite/
2015-02-04 Pedro Alves <palves@redhat.com>
* boards/native-extended-gdbserver.exp: Remove any target variant
specifications from the board name before clearing the isremote
flag from board_info.
Diff:
---
gdb/testsuite/ChangeLog | 6 ++++++
gdb/testsuite/boards/native-extended-gdbserver.exp | 4 +++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 2657987..fcc16cb 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-04 Pedro Alves <palves@redhat.com>
+
+ * boards/native-extended-gdbserver.exp: Remove any target variant
+ specifications from the board name before clearing the isremote
+ flag from board_info.
+
2015-01-31 Doug Evans <xdje42@gmail.com>
* gdb.base/maint.exp <maint print type argc>: Update expected output.
diff --git a/gdb/testsuite/boards/native-extended-gdbserver.exp b/gdb/testsuite/boards/native-extended-gdbserver.exp
index 57503db..8d299ef 100644
--- a/gdb/testsuite/boards/native-extended-gdbserver.exp
+++ b/gdb/testsuite/boards/native-extended-gdbserver.exp
@@ -27,7 +27,9 @@ load_board_description "gdbserver-base"
# matches localhost. Force it to be NOT remote.
global board
global board_info
-set board_info($board,isremote) 0
+# Remove any target variant specifications from the name.
+set baseboard [lindex [split $board "/"] 0]
+set board_info($baseboard,isremote) 0
set_board_info sockethost "localhost:"