This is the mail archive of the gdb-cvs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[binutils-gdb] libiberty/mkstemps.c: Include <time.h> if <sys/time.h> not available.


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=519b5f619baa43f000ad18c079017bea8e7fc06a

commit 519b5f619baa43f000ad18c079017bea8e7fc06a
Author: Joel Brobecker <brobecker@adacore.com>
Date:   Tue Sep 16 14:32:09 2014 -0400

    libiberty/mkstemps.c: Include <time.h> if <sys/time.h> not available.
    
    Attempting to build libiberty on LynxOS-178 fails trying to compile
    mkstemps.c with the following error:
    
        mkstemps.c:84:18: error: storage size of 'tv' isn't known
           struct timeval tv;
                          ^
    
    This file would normally include <sys/time.h> to get the type's
    definition, but unfortunately LynxOS-178 does not want us to use
    <sys/time.h>, only <time.h>. The configure script correctly finds
    this out and generates a config.h file where HAVE_SYS_TIME_H is
    undefined:
    
    /* Define to 1 if you have the <sys/time.h> header file. */
    /* #undef HAVE_SYS_TIME_H */
    
    This patch fixes the build issue by falling back on including <time.h>
    if <sys/time.h> could not be included (and provided that HAVE_TIME_H
    is defined, of course).
    
    libiberty/ChangeLog:
    
            * mkstemps.c: #include <time.h> if HAVE_TIME_H is defined
            but not HAVE_SYS_TIME_H.

Diff:
---
 libiberty/ChangeLog  | 5 +++++
 libiberty/mkstemps.c | 2 ++
 2 files changed, 7 insertions(+)

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index 5009807..923613d 100644
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-08  Joel Brobecker  <brobecker@adacore.com>
+
+	* mkstemps.c: #include <time.h> if HAVE_TIME_H is defined
+	but not HAVE_SYS_TIME_H.
+
 2015-04-22  Eli Zaretskii  <eliz@gnu.org>
 
 	* setenv.c <environ>: Declare only if not a macro.
diff --git a/libiberty/mkstemps.c b/libiberty/mkstemps.c
index a0e68a7..0e06fe1 100644
--- a/libiberty/mkstemps.c
+++ b/libiberty/mkstemps.c
@@ -35,6 +35,8 @@
 #endif
 #ifdef HAVE_SYS_TIME_H
 #include <sys/time.h>
+#elif HAVE_TIME_H
+#include <time.h>
 #endif
 #include "ansidecl.h"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]